Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC page_pools
From: Mina Almasry <hidden>
Date: 2025-11-05 22:44:52
Also in:
lkml
On Wed, Nov 5, 2025 at 1:58 PM Jesper Dangaard Brouer [off-list ref] wrote:
On 05/11/2025 21.07, Mina Almasry wrote:quoted
diff --git a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c index 0e2b703c673a..f63ffdd3b3ba 100644 --- a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c +++ b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c@@ -8,6 +8,8 @@ #include "gve.h" #include "gve_utils.h" +#include "net/netdev_queues.h" +Shouldn't this be with "<net/netdev_queues.h>" ?
Yes, will do.
And why include this and not net/page_pool/types.h that you just modified in previous patch?
netdev_queues.h is actually for netif_rxq_has_unreadable_mp. I did indeed forget to explicitly include net/page_pool/types.h for the PAGE_POOL_MAX_RING_SIZE. Will also do in v2. -- Thanks, Mina