Re: [PATCH net-next v04 2/5] hinic3: Add PF management interfaces
From: Simon Horman <horms@kernel.org>
Date: 2025-11-05 08:25:27
Also in:
linux-doc, lkml
On Wed, Oct 29, 2025 at 02:16:26PM +0800, Fan Gong wrote: ...
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c b/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c
...
+static void hinic3_print_link_message(struct net_device *netdev,
+ bool link_status_up)
+{
+ struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
+
+ if (nic_dev->link_status_up == link_status_up)
+ return;
+
+ nic_dev->link_status_up = link_status_up;
+
+ netdev_dbg(netdev, "Link is %s\n", (link_status_up ? "up" : "down"));Hi Fan Gong, all, Coccinelle suggests that str_up_down() could be used here, which does seem like a reasonable suggestion as it seems there will be a v5 anyway.
+}
...