Hi,

quoted

quoted

+				interrupt-names = "rx", "emac_ptp_tx",
+								"hsr_ptp_tx";

Something looks wrong with the indentation here. The same happens in
at least one other place.

we will correct the indentation of the interrupt-names property to properly
align the continuation line as shown below.

interrupt-names = "rx", "emac_ptp_tx",
                 "hsr_ptp_tx";

We will make sure to address this in all the applicable places and include
this fix in the next version.

quoted

quoted

+&pruss2_mdio {
+	status = "okay";
+	pruss2_eth0_phy: ethernet-phy@0 {
+		reg = <0>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
+	};
+
+	pruss2_eth1_phy: ethernet-phy@1 {
+		reg = <1>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
+	};

PHY interrupts are 99% level, not edge, because they represent an
interrupt controller in the PHY, and you need to clear all the
interrupts in the controller before it deasserts the interrupt pin.

   Andrew

Sure, we will check and come back with more details on this.

We have reviewed and analysed the code, and confirmed that level
low can be used for the PHY interrupt, which seems to be a better
option than using the edge falling.

As shown below, the current interrupt configuration reflects a
level-triggered setup:

root@am57xx-evm:~# cat /proc/interrupts
           CPU0       CPU1    
163:          2          0 48057000.gpio  30 Level     4b2b2400.mdio:00
164:          2          0 48057000.gpio  31 Level     4b2b2400.mdio:01

We can see the IRQ has been changed to Level and the count is incremented
for every link event.

We will update the interrupt type to IRQ_TYPE_LEVEL_LOW as shown below and
share the next version.

+&pruss2_mdio {
+       status = "okay";
+       pruss2_eth0_phy: ethernet-phy@0 {
+               reg = <0>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
+       };
+
+       pruss2_eth1_phy: ethernet-phy@1 {
+               reg = <1>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+       };
+};


Thanks and Regards,
Parvathi.