From: Jakub Kicinski <kuba@kernel.org>
Sent: 18 November 2025 09:11 AM

On Sat, 15 Nov 2025 04:51:25 +0200 Parav Pandit wrote:

quoted

+	err = devlink_nl_eswitch_fill(msg, devlink,

DEVLINK_CMD_ESWITCH_SET,

I've never seen action command ID being used for a notification.
Either use an existing type which has the same message format, or if no
message which naturally fits exists allocate a new ID.

I am not sure fully.
1. devlink_notify() uses DEVLINK_CMD_NEW.

2. devlink_port_notify() uses DEVLINK_CMD_PORT_NEW which is the input cmd on port creation supplied by the user space.

3. devlink_params_notify_register() uses DEVLINK_CMD_PARAM_NEW.

Do you mean #1 and #3 are not user-initiated commands, hence such an action command ID is ok vs #2 is not ok?
I probably misunderstanding your comment.