Re: [RFC PATCH net-next v2 2/2] net: ethernet: Implement ndo_write_rx_config callback for the 8139cp driver
From: Simon Horman <horms@kernel.org>
Date: 2025-10-28 15:17:47
Also in:
linux-kernel-mentees, lkml
On Sun, Oct 26, 2025 at 11:24:45PM +0530, I Viswanath wrote:
Implement ndo_write_rx_config for the 8139cp driver Signed-off-by: I Viswanath <redacted>
...
quoted hunk ↗ jump to hunk
@@ -882,55 +886,53 @@ static netdev_tx_t cp_start_xmit (struct sk_buff *skb, goto out_unlock; } +static void cp_write_rx_config(struct net_device *dev) +{ + struct cp_private *cp = netdev_priv(dev); + struct cp_rx_config snapshot; + + read_snapshot((&snapshot), struct cp_private); + + /* We can safely update without stopping the chip. */ + cpw32_f(RxConfig, snapshot.rx_mode); + + cpw32_f(MAR0 + 0, snapshot.mc_filter[0]); + cpw32_f(MAR0 + 4, snapshot.mc_filter[1]); +}Firstly, think whether you have a bug fix or new "next-like" content.Then once decided, assuming that you use git, use the prefix flag, i.e.
FWIIW, this patch is mangled, e.g. the lines above.
+
/* Set or clear the multicast filter for this adaptor.
This routine is not state sensitive and need not be SMP locked. */...