Thread (9 messages) 9 messages, 4 authors, 2025-10-26

Re: [PATCH net-next 1/3] net: dsa: yt921x: Add STP/MST support

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-10-26 23:54:49
Also in: lkml

+static int
+yt921x_dsa_vlan_msti_set(struct dsa_switch *ds, struct dsa_bridge bridge,
+			 const struct switchdev_vlan_msti *msti)
+{
+	struct yt921x_priv *priv = to_yt921x_priv(ds);
+	u64 mask64;
+	u64 ctrl64;
+	int res;
+
+	if (!msti->vid)
+		return -EINVAL;
+	if (msti->msti <= 0 || msti->msti >= YT921X_MSTI_NUM)
+		return -EINVAL;
I see there are a bunch of build bot warning emails, so this might be
covered already?

msti->msti is a u16. It cannot by < 0, so <= should be =.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help