Thread (2 messages) 2 messages, 2 authors, 2025-10-24
STALE246d

[PATCH net-next] net: dsa: yt921x: Fix missing type casting to u64

From: David Yang <mmyangfl@gmail.com>
Date: 2025-10-24 08:49:50
Also in: lkml
Subsystem: motorcomm yt921x ethernet switch driver, networking drivers, networking [dsa], the rest · Maintainers: David Yang, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean, Linus Torvalds

Reported by the following Smatch static checker warning:

  drivers/net/dsa/yt921x.c:702 yt921x_read_mib()
  warn: was expecting a 64 bit value instead of '(~0)'

Reported-by: Dan Carpenter <redacted>
Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ (local)
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
 drivers/net/dsa/yt921x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c
index ab762ffc4661..8baed8107512 100644
--- a/drivers/net/dsa/yt921x.c
+++ b/drivers/net/dsa/yt921x.c
@@ -699,7 +699,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port)
 			if (val < (u32)val)
 				/* overflow */
 				val += (u64)U32_MAX + 1;
-			val &= ~U32_MAX;
+			val &= ~(u64)U32_MAX;
 			val |= val0;
 		} else {
 			res = yt921x_reg_read(priv, reg + 4, &val1);
-- 
2.51.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help