Re: [PATCH v2 net] sfc: fix potential memory leak in efx_mae_process_mport()

From
Jacob Keller <jacob.e.keller@intel.com>
Date
2025-10-24 00:48:18
Also in
lkml
Reply to
Abdun Nihaal, 2025-10-23

On 10/23/2025 7:18 AM, Abdun Nihaal wrote:
In efx_mae_enumerate_mports(), memory allocated for mae_mport_desc is
passed as a argument to efx_mae_process_mport(), but when the error path
in efx_mae_process_mport() gets executed, the memory allocated for desc
gets leaked.

Fix that by freeing the memory allocation before returning error.
Why not make the caller responsible for freeing desc on failure?

Attachments

Thread (6 messages) 6 messages, 4 authors, last reply 2025-10-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help