Thread (3 messages) 3 messages, 2 authors, 2025-10-20

Re: [PATCH bpf-next] bpf/cpumap.c: Remove unnecessary TODO comment

From: Mehdi Ben Hadj Khelifa <hidden>
Date: 2025-10-20 15:45:31
Also in: bpf, linux-kernel-mentees, lkml

On 10/20/25 4:41 PM, Alexander Lobakin wrote:
From: Mehdi Ben Hadj Khelifa <redacted>
Date: Sun, 19 Oct 2025 17:58:55 +0100
quoted
After discussion with bpf maintainers[1], queue_index could
be propagated to the remote XDP program by the xdp_md struct[2]
But it's not done automatically, so not aware users may get confused.

Instead of just removing the TODO, I believe you should leave a comment
here that the RxQ index gets lots after the frame is redirected, so if
someone really wants it, he/she should use <what the second link says>.
Logical,I will send a v2 soon.
Thanks for the review.

Best Regards,
Mehdi Ben Hadj Khelifa>> which makes this todo a misguide for future effort.
quoted
[1]:https://lore.kernel.org/all/87y0q23j2w.fsf@cloudflare.com/ (local)
[2]:https://docs.ebpf.io/linux/helper-function/bpf_xdp_adjust_meta/

Signed-off-by: Mehdi Ben Hadj Khelifa <redacted>
Thanks,
Olek
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help