Re: [PATCH 10/15] arm64: dts: mediatek: mt7981b: Add Ethernet and WiFi offload support
From: Daniel Golle <daniel@makrotopia.org>
Date: 2025-10-20 12:18:20
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, linux-pci, linux-phy, lkml
On Mon, Oct 20, 2025 at 12:27:53PM +0200, AngeloGioacchino Del Regno wrote:
Il 16/10/25 18:47, Daniel Golle ha scritto:quoted
On Thu, Oct 16, 2025 at 12:08:46PM +0200, Sjoerd Simons wrote:quoted
Add device tree nodes for the Ethernet subsystem on MT7981B SoC, including: - Ethernet MAC controller with dual GMAC support - Wireless Ethernet Dispatch (WED) - SGMII PHY controllers for high-speed Ethernet interfaces - Reserved memory regions for WiFi offload processor Signed-off-by: Sjoerd Simons <redacted> --- arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 133 ++++++++++++++++++++++++++++++ 1 file changed, 133 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi index 13950fe6e8766..c85fa0ddf2da8 100644 --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi..snip..quoted
quoted
+ + mdio_bus: mdio-bus { + #address-cells = <1>; + #size-cells = <0>; + + int_gbe_phy: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + phy-mode = "gmii"; + phy-is-integrated; + nvmem-cells = <&phy_calibration>; + nvmem-cell-names = "phy-cal-data";Please also define the two LEDs here with their corresponding (only) pinctrl options for each of them, with 'status = "disabled";'. This makes it easier for boards to make use of the Ethernet PHY leds by just referencing the LED and setting the status to 'okay'.Sorry Daniel, definitely no. The LEDs really are board specific. Try to convince me otherwise, but for this one I really doubt that you can.
You are right, the LEDs themselves are board-specific and may not even be present. However, the LED controller is always present because it is part of the PHY which is built-into the SoC. And the pinctrl property which I'd like to see described on SoC-level is a property of the LED controller rather than the LED itself. Sadly the device tree node doesn't make the distinction between LED and LED controller, so I understand you your argument as well.