Re: [net-next PATCH] net: phy: as21xxx: fill in inband caps and better handle inband

From
Russell King (Oracle) <linux@armlinux.org.uk>
Date
2025-10-16 15:23:55
Also in
lkml
Reply to
Christian Marangi, 2025-10-16
On Thu, Oct 16, 2025 at 05:20:07PM +0200, Christian Marangi wrote:
quoted hunk ↗ jump to hunk
+static int as21xxx_config_inband(struct phy_device *phydev,
+				 unsigned int modes)
+{
+	if (modes == LINK_INBAND_ENABLE)
+		return aeon_dpc_ra_enable(phydev);
So what happens when phylink requests inband to be disabled?

I really don't like implementations that enable something but then
provide no way to disable it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Thread (3 messages) 3 messages, 2 authors, last reply 2025-10-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help