Thread (11 messages) 11 messages, 2 authors, 2025-11-10

Re: [PATCH net-next v3 1/3] net: ti: icssm-prueth: Adds helper functions to configure and maintain FDB

From: Parvathi Pudi <parvathi@couthit.com>
Date: 2025-10-16 11:40:23
Also in: linux-arm-kernel, lkml

Hi,
quoted
+/* 4 bytes */
+struct fdb_index_tbl_entry_t {
+	/* Bucket Table index of first Bucket with this MAC address */
+	u16 bucket_idx;
+	u16 bucket_entries; /* Number of entries in this bucket */
+};
Please drop the _t. That is normally used to indicate a type, but this
is actually a struct
Sure. We will remove _t from the struct definitions.
quoted
+void icssm_prueth_sw_fdb_tbl_init(struct prueth *prueth)
+{
+	struct fdb_tbl *t = prueth->fdb_tbl;
+
+	t->index_a = (struct fdb_index_array_t *)((__force const void *)
+			prueth->mem[V2_1_FDB_TBL_LOC].va +
+			V2_1_FDB_TBL_OFFSET);
You cast it to a const void * and then a non-const fdb_index_array_t *?
We will address this and remove the double casting completely.

Thanks and Regards,
Parvathi.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help