Re: [PATCH RFC net-next] net: drop_monitor: Add debugfs support

From
Simon Horman <horms@kernel.org>
Date
2025-10-15 16:49:59
Also in
lkml
Reply to
Florian Westphal, 2025-10-15
On Wed, Oct 15, 2025 at 01:14:47PM +0200, Florian Westphal wrote:
quoted hunk ↗ jump to hunk
Eric Dumazet [off-list ref] wrote:
quoted
I do not understand the fascination with net/core/drop_monitor.c,
which looks very old school to me,
and misses all the features,  flexibility, scalability  that 'perf',
eBPF tracing, bpftrace, .... have today.

Adding  /sys/kernel/debug/drop_monitor/* is even more old school.

Not mentioning the maintenance burden.

For me the choice is easy :

# CONFIG_NET_DROP_MONITOR is not set

perf record -ag -e skb:kfree_skb sleep 1

perf script # or perf report
Maybe:
diff --git a/net/Kconfig b/net/Kconfig
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -400,15 +400,15 @@ config NET_PKTGEN
          module will be called pktgen.

 config NET_DROP_MONITOR
-       tristate "Network packet drop alerting service"
+       tristate "Legacy network packet drop alerting service"
+1

...
Thread (5 messages) 5 messages, 4 authors, last reply 2025-10-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help