Thread (5 messages) 5 messages, 4 authors, 2025-10-14

Re: [PATCH] Octeontx2-af: Fix missing error code in cgx_probe()

From: Simon Horman <horms@kernel.org>
Date: 2025-10-13 09:23:32
Also in: kernel-janitors, lkml

On Fri, Oct 10, 2025 at 01:42:39PM -0700, Harshit Mogalapalli wrote:
When CGX fails mapping to NIX, set the error code to -ENODEV, currently
err is zero and that is treated as success path.

Reported-by: Dan Carpenter <redacted>
Closes: https://lore.kernel.org/all/aLAdlCg2_Yv7Y-3h@stanley.mountain/ (local)
Fixes: d280233fc866 ("Octeontx2-af: Fix NIX X2P calibration failures")
Signed-off-by: Harshit Mogalapalli <redacted>
---
This is based on static analysis with smatch and only compile tested.
Thanks,

I agree that Smatch is onto something here.

Reviewed-by: Simon Horman <horms@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help