Thread (12 messages) 12 messages, 5 authors, 2025-10-15

Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks

From: Markus Elfring <hidden>
Date: 2025-10-12 13:27:24
Also in: kernel-janitors, linux-arm-kernel, linux-aspeed, linux-doc, linux-kselftest, lkml

This patch extends the …
Will another imperative wording approach become more helpful for an improved
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94
quoted hunk ↗ jump to hunk
+++ b/kernel/hung_task.c
@@ -229,9 +232,11 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
 	trace_sched_process_hang(t);
 
-	if (sysctl_hung_task_panic) {
+	if (sysctl_hung_task_panic &&
+			(total_hung_task >= sysctl_hung_task_panic)) {
…

I suggest to use the following source code variant instead.

	if (sysctl_hung_task_panic && total_hung_task >= sysctl_hung_task_panic) {


Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help