Thread (5 messages) 5 messages, 3 authors, 2025-10-09

Re: [PATCH net] net: usb: lan78xx: fix use of improperly initialized dev->chipid in lan78xx_reset

From: I Viswanath <hidden>
Date: 2025-10-09 16:57:37
Also in: linux-kernel-mentees, linux-usb, lkml

On Mon, 6 Oct 2025 at 23:42, Jakub Kicinski [off-list ref] wrote:
We need a Fixes tag
a0db7d10b76e ("lan78xx: Add to handle mux control per chip id") seems
to be most suitable commit: It added dev->devid comparisons to
lan78xx_read_raw_eeprom but did not move the dev->devid read before
the call (devid is the precursor to chipid and chiprev)

I feel like the patch title sounds a bit awkward so should I change it to

"Initialize dev->chipid before use in lan78xx_read_raw_eeprom"

since that sounds more standard

in v2

Thanks
I Viswanath
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help