Thread (8 messages) 8 messages, 3 authors, 2025-10-07

Re: [PATCH] net: phy: microchip_t1: LAN887X: Fix device init issues.

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-10-06 18:44:59
Also in: lkml

phy_sanitize_settings() is supposed to pick the least supported
speed from the supported list when speed is not initialized.
What makes you think it should pick the slowest speed? The kdoc for
the function is:

/**
 * phy_sanitize_settings - make sure the PHY is set to supported speed and duplex
 * @phydev: the target phy_device struct
 *
 * Description: Make sure the PHY is set to supported speeds and
 *   duplexes.  Drop down by one in this order:  1000/FULL,
 *   1000/HALF, 100/FULL, 100/HALF, 10/FULL, 10/HALF.

So it should pick 1000Full if available. If not it will try 1000Half,
if not 100Full etc.

And the comment is actually a bit out of date. It will actually start
from 800G Full, 400G Full, 200G Full, 100G Full, not that anybody does
Copper at these speeds.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help