Re: [PATCH] net: usb: lan78xx: Fix lost EEPROM read timeout error(-ETIMEDOUT) in lan78xx_read_raw_eeprom
- From
- Jakub Kicinski <kuba@kernel.org>
- Date
- 2025-10-01 00:39:52
- Also in
- linux-usb, lkml
- Reply to
- Bhanu Seshu Kumar Valluri, 2025-09-30
On Tue, 30 Sep 2025 14:19:02 +0530 Bhanu Seshu Kumar Valluri wrote:
quoted hunk ↗ jump to hunk
+ if (dev->chipid == ID_REV_CHIP_ID_7800_) { + int rc = lan78xx_write_reg(dev, HW_CFG, saved); + /* If USB fails, there is nothing to do */ + if (rc < 0) + return rc; + } + return ret;
I don't think you need to add and handle rc here separately? rc can only be <= so save the answer to ret and "fall thru"? -- pw-bot: cr