Thread (3 messages) 3 messages, 2 authors, 2025-10-28

Re: [PATCH net v1] net: io_uring/zcrx: call netdev_queue_get_dma_dev() under instance lock

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-10-28 22:38:22
Also in: io-uring

On Tue, 28 Oct 2025 14:26:39 -0700 David Wei wrote:
netdev ops must be called under instance lock or rtnl_lock, but
io_register_zcrx_ifq() isn't doing this for netdev_queue_get_dma_dev().

Fix this by taking the instance lock.

Opted to do this by hand instead of netdev_get_by_index_lock(), which is
an older helper that doesn't take netdev tracker.
Fixes tag missing.

netdev_get_by_index_lock() + netdev_hold() would be a better choice indeed.
Just a reference doesn't hold off device shutdown.

Is there a chance to reorder the io_zcrx_create_area() call, keep
holding the lock and call __net_mp_open_rxq() ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help