Re: [PATCH net-next v3 2/4] amd-xgbe: add ethtool phy selftest
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2025-10-20 16:20:07
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2025-10-20 16:20:07
Hi Raju, On 20/10/2025 17:22, Raju Rangoju wrote:
Adds support for ethtool PHY loopback selftest. It uses genphy_loopback function, which use BMCR loopback bit to enable or disable loopback. Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
This all looks a lot like the stmmac selftests, hopefully one day we can extract that logic into a more generic selftest framework for all drivers to use. But in any case, this looks good to me :) Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Maxime