On Mon, 13 Oct 2025 03:56:35 -0400, "Michael S. Tsirkin" [off-list ref] wrote:

On Mon, Oct 13, 2025 at 10:06:26AM +0800, Xuan Zhuo wrote:

quoted

As discussed in http://lore.kernel.org/all/20250919013450.111424-1-xuanzhuo@linux.alibaba.com (local)
Commit #1 Move the flags into the existing if condition; the issue is that it introduces a
small amount of code duplication.

How were commits 1 and 2 tested?

These two are not troublesome. I tested #1 in big mode. #2 has no special
requirements. I tested it on qemu and observed the hdr len.

Thanks.

quoted

Commit #3 is new to fix the hdr len in tunnel gso feature.

Hi @Paolo Abenchi,
Could you please test commit #3? I don't have a suitable test environment, as
QEMU doesn't currently support the tunnel GSO feature.

Thanks.

AFAIK host_tunnel and guest_tunnel flags enable exactly that.

quoted

Xuan Zhuo (3):
  virtio-net: fix incorrect flags recording in big mode
  virtio-net: correct hdr_len handling for VIRTIO_NET_F_GUEST_HDRLEN
  virtio-net: correct hdr_len handling for tunnel gso

 drivers/net/virtio_net.c   | 16 ++++++++-----
 include/linux/virtio_net.h | 46 ++++++++++++++++++++++++++++++++------
 2 files changed, 50 insertions(+), 12 deletions(-)

--
2.32.0.3.g01195cf9f