Re: [PATCH net-next] bonding: Remove support for use_carrier

From
Nikolay Aleksandrov <razor@blackwall.org>
Date
2025-09-03 09:53:56
Also in
linux-doc
Reply to
Nikolay Aleksandrov, 2025-09-03
On 9/3/25 12:50, Nikolay Aleksandrov wrote:
On 9/2/25 19:11, Stanislav Fomichev wrote:
quoted
On 08/29, Jay Vosburgh wrote:
[snip]
quoted
quoted
      return 0;
Acked-by: Stanislav Fomichev <sdf@fomichev.me>

nit: any reason not to return -EINVAL here when the new value is not "1"?
You do it for the module param, but not for the sysfs file here.
bond options code already returns EINVAL for values not described in the option's value
table, after Jay removed "0" from there it should automatically cause -EINVAL to be returned
Still fixing email problems, I see now that this is an old thread.
Please ignore my reply, sorry for the noise!

Cheers,
 Nik
Thread (9 messages) 9 messages, 5 authors, last reply 2025-09-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help