On 9/25/25 9:40 AM, Chia-Yu Chang (Nokia) wrote:

quoted

-----Original Message-----
From: Paolo Abeni <pabeni@redhat.com> 
Sent: Tuesday, September 23, 2025 11:48 AM
To: Chia-Yu Chang (Nokia) <redacted>; edumazet@google.com; linux-doc@vger.kernel.org; corbet@lwn.net; horms@kernel.org; dsahern@kernel.org; kuniyu@amazon.com; bpf@vger.kernel.org; netdev@vger.kernel.org; dave.taht@gmail.com; jhs@mojatatu.com; kuba@kernel.org; stephen@networkplumber.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; andrew+netdev@lunn.ch; donald.hunter@gmail.com; ast@fiberby.net; liuhangbin@gmail.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; ij@kernel.org; ncardwell@google.com; Koen De Schepper (Nokia) <redacted>; g.white@cablelabs.com; ingemar.s.johansson@ericsson.com; mirja.kuehlewind@ericsson.com; cheshire@apple.com; rs.ietf@gmx.at; Jason_Livingood@comcast.com; vidhi_goel@apple.com
Cc: Olivier Tilmans (Nokia) <redacted>
Subject: Re: [PATCH v2 net-next 03/14] tcp: accecn: Add ece_delta to rate_sample


CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



On 9/18/25 6:21 PM, chia-yu.chang@nokia-bell-labs.com wrote:

quoted

From: Ilpo Järvinen <ij@kernel.org>

Include echoed CE count into rate_sample. Replace local ecn_count 
variable with it.

Why? skimming over the next few patches it's not clear to me which is the goal here.

Expanding the commit message would help, thanks!

Paolo

Hi Paolo,

Sorry for my late reply.
Here, ece_delata will be used in the next patch series by tcp_prague (or other congestion control algorithm) that support Prague requirement to adjust the congestion window accordingly.
I will elaborate more on the patch notes, or you think this shall stay in the tcp_prague patch series?

I think the latter would be the better option.

Thanks,

Paolo