Thread (2 messages) 2 messages, 2 authors, 2025-09-25

Re: [PATCH RESEND net v3] net: nfc: nci: Add parameter validation for packet data

From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-09-25 08:45:21
Also in: linux-kernel-mentees, stable

On 9/21/25 8:23 PM, Deepak Sharma wrote:
quoted hunk ↗ jump to hunk
 static int nci_extract_activation_params_iso_dep(struct nci_dev *ndev,
@@ -501,7 +536,7 @@ static int nci_store_general_bytes_nfc_dep(struct nci_dev *ndev,
 	case NCI_NFC_A_PASSIVE_POLL_MODE:
 	case NCI_NFC_F_PASSIVE_POLL_MODE:
 		ndev->remote_gb_len = min_t(__u8,
-			(ntf->activation_params.poll_nfc_dep.atr_res_len
+					    (ntf->activation_params.poll_nfc_dep.atr_res_len
 						- NFC_ATR_RES_GT_OFFSET),
 			NFC_ATR_RES_GB_MAXSIZE);
 		memcpy(ndev->remote_gb,
@@ -513,7 +548,7 @@ static int nci_store_general_bytes_nfc_dep(struct nci_dev *ndev,
 	case NCI_NFC_A_PASSIVE_LISTEN_MODE:
 	case NCI_NFC_F_PASSIVE_LISTEN_MODE:
 		ndev->remote_gb_len = min_t(__u8,
-			(ntf->activation_params.listen_nfc_dep.atr_req_len
+					    (ntf->activation_params.listen_nfc_dep.atr_req_len
 						- NFC_ATR_REQ_GT_OFFSET),
 			NFC_ATR_REQ_GB_MAXSIZE);
 		memcpy(ndev->remote_gb,
I'm sorry for the late feedback. The above 2 chunks looks unrelated from
the real fix, please drop them: they will make stable teams work more
difficult for no good reason.

Thanks,

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help