On 9/26/2025 12:30 AM, Adam Young wrote:

+static int initialize_MTU(struct net_device *ndev)
+{
+	struct mctp_pcc_ndev *mctp_pcc_ndev = netdev_priv(ndev);
+	struct mctp_pcc_mailbox *outbox;
+	int mctp_pcc_mtu;
+
+	outbox = &mctp_pcc_ndev->outbox;
+	outbox->chan = pcc_mbox_request_channel(&outbox->client, outbox->index);
+	mctp_pcc_mtu = outbox->chan->shmem_size - sizeof(struct pcc_header);

de-reference outbox->chan->shmem_size before checking IS_ERR(outbox->chan)

+	if (IS_ERR(outbox->chan))
+		return PTR_ERR(outbox->chan);
+
+	pcc_mbox_free_channel(mctp_pcc_ndev->outbox.chan);
+
+	mctp_pcc_ndev = netdev_priv(ndev);
+	ndev->mtu = MCTP_MIN_MTU;
+	ndev->max_mtu = mctp_pcc_mtu;
+	ndev->min_mtu = MCTP_MIN_MTU;
+
+	return 0;
+}

Thanks,
Alok