Thread (6 messages) 6 messages, 5 authors, 2025-09-25

Re: [PATCH net-next V5] net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs

From: Patrisious Haddad <hidden>
Date: 2025-09-25 12:15:55
Also in: linux-arch, linux-patches, linux-rdma, linux-s390, lkml, llvm

On 9/25/2025 2:54 PM, Jason Gunthorpe wrote:
On Thu, Sep 25, 2025 at 02:48:33PM +0300, Tariq Toukan wrote:
quoted
+static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
+				size_t mmio_wqe_size, unsigned int offset)
+{
+#if defined(CONFIG_KERNEL_MODE_NEON) && defined(CONFIG_ARM64)
IS_ENABLED() not defined()
I just wonder why, Is there a preference in the driver from like 
aesthetic/convention point of view?
Since here it technically doesnt matter - IS_ENABLED have no functional 
difference from defined since these are boolean configs not 
*tristate*ones (cant be loaded as module).

Patrisious.
Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help