Thread (15 messages) 15 messages, 5 authors, 2025-09-25

Re: [PATCH net v2] net: usb: Remove disruptive netif_wake_queue in rtl8150_set_multicast

From: Michal Pecio <hidden>
Date: 2025-09-24 09:37:00
Also in: linux-kernel-mentees, linux-usb, lkml

On Wed, 24 Sep 2025 13:32:52 +0530, viswanath wrote:
On Wed, 24 Sept 2025 at 13:17, Michal Pecio [off-list ref] wrote:
quoted
It's not freeing which matters but URB completion in the USB subsystem.  
Does URB completion include both successful and failed completions? I
decided to go with "free urb" because I wasn't sure of that.
I think yes, usually in USB-speak "completion" is when the URB is
finished for any reason, including error or unlink/cancellation.
"Free" could suggest usb_free_urb().

But I see your point. Maybe "finish execution" is less ambiguous?
I wasn't sure how to describe the flow of execution in a multi threaded program.
I will resubmit a v3 with this version of the execution flow
I think it's an irrelevant detail which CPU executed which function.
It could all happen sequentially on a single core and it's still the
same bug.

In fact, I just reproduced it with all CPUs offlined except one.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help