Re: [PATCH net] octeontx2-pf: Fix potential use after free in otx2_tc_add_flow()
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Date: 2025-09-23 11:54:59
Also in:
kernel-janitors, lkml
On 23/09/2025 12:19, Dan Carpenter wrote:
This code calls kfree_rcu(new_node, rcu) and then dereferences "new_node"
and then dereferences it on the next line. Two lines later, we take
a mutex so I don't think this is an RCU safe region. Re-order it to do
the dereferences before queuing up the free.
Fixes: 68fbff68dbea ("octeontx2-pf: Add police action for TC flower")
Signed-off-by: Dan Carpenter <redacted>Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>