Thread (10 messages) flat view 10 messages, 4 authors, 2025-09-25

Re: [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage()

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2025-09-22 22:09:25
Also in: linux-can, lkml

On Sun, 21 Sep 2025 16:32:32 +0900
Vincent Mailhol [off-list ref] wrote:
usage() is called either if the user passes the "help" argument or passes
an invalid argument.

Factorise those two cases together.

This silences below checkpatch.pl warning:

  WARNING: else is not generally useful after a break or return
  #274: FILE: ip/iplink_can.c:274:
  +			return -1;
  +		} else {

Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
Not accepting most checkpatch stuff in iproute2.
Better to not have code churn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help