Thread (5 messages) 5 messages, 5 authors, 2025-09-20

Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-09-20 00:10:06
Also in: kernel-janitors, linux-arm-kernel, lkml

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 18 Sep 2025 12:48:26 +0300 you wrote:
This error handling triggers a Smatch warning:

    drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe()
    warn: 'prueth->pru1' is an error pointer or valid

The warning is harmless because the pru_rproc_put() function has an
IS_ERR_OR_NULL() check built in.  However, there is a small bug if
syscon_regmap_lookup_by_phandle() fails.  In that case we should call
of_node_put() on eth0_node and eth1_node.

[...]
Here is the summary with links:
  - [net-next] net: ti: icssm-prueth: unwind cleanly in probe()
    https://git.kernel.org/netdev/net-next/c/5fc7fa743dbf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help