Thread (3 messages) 3 messages, 3 authors, 2025-09-19

Re: [PATCH net-next] hinic3: Fix NULL vs IS_ERR() check in hinic3_alloc_rxqs_res()

From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Date: 2025-09-18 12:58:02
Also in: kernel-janitors, lkml

On 18/09/2025 10:45, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
The page_pool_create() function never returns NULL, it returns
error pointers.  Update the check to match.

Fixes: 73f37a7e1993 ("hinic3: Queue pair resource initialization")
Signed-off-by: Dan Carpenter <redacted>
---
  drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
index 6cfe3bdd8ee5..16c00c3bb1ed 100644
--- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
+++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
@@ -414,7 +414,7 @@ int hinic3_alloc_rxqs_res(struct net_device *netdev, u16 num_rq,
  		pp_params.dma_dir = DMA_FROM_DEVICE;
  		pp_params.max_len = PAGE_SIZE;
  		rqres->page_pool = page_pool_create(&pp_params);
-		if (!rqres->page_pool) {
+		if (IS_ERR(rqres->page_pool)) {
  			netdev_err(netdev, "Failed to create rxq%d page pool\n",
  				   idx);
  			goto err_free_cqe;
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help