Re: [v7, net-next 01/10] bng_en: make bnge_alloc_ring() self-unwind on failure

On Tue, Sep 16, 2025 at 8:43 PM Simon Horman [off-list ref] wrote:

On Fri, Sep 12, 2025 at 01:04:56AM +0530, Bhargava Marreddy wrote:

quoted

Ensure bnge_alloc_ring() frees any intermediate allocations
when it fails. This enables later patches to rely on this
self-unwinding behavior.

Signed-off-by: Bhargava Marreddy <redacted>
Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Rajashekar Hudumula <redacted>

Without this patch(set), does the code correctly release resources on error?

If not, I think this should be considered a fix for net with appropriate
Fixes tag(s).

Thanks for your feedback, Simon. This patch doesn't introduce a fix;
the code already frees resources correctly.
Instead, it modifies error handling by changing from caller-unwind to
self-unwind within this function

...