Thread (2 messages) 2 messages, 2 authors, 2025-09-16

Re: [PATCH net v2] net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-09-16 02:20:05
Also in: lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Sat, 13 Sep 2025 15:01:36 +0900 you wrote:
`netif_rx()` already increments `rx_dropped` core stat when it fails.
The driver was also updating `ndev->stats.rx_dropped` in the same path.
Since both are reported together via `ip -s -s` command, this resulted
in drops being counted twice in user-visible stats.

Keep the driver update on `if (unlikely(!skb))`, but skip it after
`netif_rx()` errors.

[...]
Here is the summary with links:
  - [net,v2] net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure
    https://git.kernel.org/netdev/net/c/93ab4881a4e2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help