Thread (17 messages) 17 messages, 2 authors, 2025-09-16

Re: [PATCH net-next v5 1/5] ethtool: introduce core UAPI and driver API for PHY MSE diagnostics

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-09-12 23:54:43
Also in: linux-doc, lkml

On Fri, 12 Sep 2025 12:21:11 +0200 Oleksij Rempel wrote:
quoted
quoted
All investigated devices differ in MSE configuration parameters, such
as sample rate, number of analyzed symbols, and scaling factors.
For example, the KSZ9131 uses different scaling for MSE and pMSE.
To make this visible to userspace, scale limits and timing information
are returned via get_mse_config().  
But the parameter set is set by the standard? If not we should annotate
which one is and which isn't.  
Do you mean we should show which parameters are defined by a standard
(for example Open-Alliance - MSE/pMSE) or which parts of the measurement
method - like how many samples in what time - are vendor or product
specific?
Yes. Your call if it really makes sense, but if we have a mix it's good
to mention which ones are safe(r) to depend on in mixed environments.
One way to do this would be to annotate the standard ones with standard
references but doesn't seem like the OA standard lends itself to
concise ways of referring to it (like IEEE standards do).
And should we only write this in comments/docs, or add a flag/enum so
user space can detect it?
Just comments/docs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help