Re: [PATCH v6 2/2] ethernet: eswin: Add eic7700 ethernet driver
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-09-12 20:30:52
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-09-12 20:30:52
Also in:
linux-arm-kernel, linux-devicetree, lkml
+ /* Read rx-internal-delay-ps and update rx_clk delay */
+ if (!of_property_read_u32(pdev->dev.of_node,
+ "rx-internal-delay-ps", &delay_ps)) {
+ u32 val = min(delay_ps / 100, EIC7700_MAX_DELAY_UNIT);
+
+ eth_dly_param &= ~EIC7700_ETH_RX_ADJ_DELAY;
+ eth_dly_param |= FIELD_PREP(EIC7700_ETH_RX_ADJ_DELAY, val);
+ } else {
+ dev_warn(&pdev->dev, "can't get rx-internal-delay-ps\n");
+ }The binding specifies the X-internal-delay-ps values are required. So this should be dev_err_probe() and return -EINVAL to stop the probe. Andrew