Thread (5 messages) flat view 5 messages, 3 authors, 2025-09-12

Re: [PATCH net] net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure

From: Yeounsu Moon <hidden>
Date: 2025-09-12 14:01:54
Also in: lkml

On Fri Sep 12, 2025 at 10:21 PM KST, Simon Horman wrote:
Thanks for your patch,
Thank you very much for your review, Simon :)
Thinking out loud: Adding use of ndev->stats to drivers that don't already
do so is discouraged. But here, an existing use is being fixed. And I agree
it is a fix. So this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>
I also noticed that many drivers are still using `ndev->stats`.
If I work on related changes in the future, I will make sure to use
`struct rtnl_link_stats64` instaed and post patches accordingly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help