Thread (8 messages) 8 messages, 4 authors, 2025-09-15

Re: [PATCH] net/smc: replace strncpy with strscpy for ib_name

From: Mahanta Jambigi <mjambigi@linux.ibm.com>
Date: 2025-09-12 07:49:19
Also in: linux-kernel-mentees, linux-rdma, linux-s390, lkml

On 10/09/25 3:31 pm, Leon Romanovsky wrote:
quoted
--- a/net/smc/smc_pnet.c
+++ b/net/smc/smc_pnet.c
@@ -450,7 +450,7 @@ static int smc_pnet_add_ib(struct smc_pnettable *pnettable, char *ib_name,
 		return -ENOMEM;
 	new_pe->type = SMC_PNET_IB;
 	memcpy(new_pe->pnet_name, pnet_name, SMC_MAX_PNETID_LEN);
-	strncpy(new_pe->ib_name, ib_name, IB_DEVICE_NAME_MAX);
+	strscpy(new_pe->ib_name, ib_name);
It is worth to mention that caching ib_name is wrong as IB/core provides
IB device rename functionality.
In our case we hit this code path where we pass *PCI_ID*
as the *ib_name* using *smc_pnet* tool(smc_pnet -a <pnet_name> -D
<PCI_ID>). I believe PCI_ID will not change, so caching it here is fine.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help