Re: [PATCH] net: ethernet: sun4i-emac: free dma descriptor

From
李克斯 <hidden>
Date
2025-09-09 06:43:11
Also in
dmaengine, linux-arm-kernel, lkml
Reply to
Jakub Kicinski, 2025-09-08
Thank you for the suggestion. I've reviewed the documentation, and setting the reuse flag while reusing descriptors might be a good optimization. I'll make the changes and run some tests. If everything works well, I'll submit a new patch.
2025年9月9日 04:26,Jakub Kicinski [off-list ref] 写道:

On Sun,  7 Sep 2025 19:29:30 +0800 Conley Lee wrote:
quoted
In the current implementation of the sun4i-emac driver, when using DMA to
receive data packets, the descriptor for the current DMA request is not
released in the rx_done_callback.
I wish you elaborated more on the reuse flag not being set :\
quoted
Fix this by properly releasing the descriptor.

Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support")
Signed-off-by: Conley Lee <redacted>
Hi Vinod, could you TAL? Is this fix legit or there's something wrong
with how the DMA engine API is used on this platform?
https://lore.kernel.org/all/tencent_D434891410B0717BB0BDCB1434969E6EB50A@qq.com/ (local)
  
Thread (9 messages) 9 messages, 2 authors, last reply 2025-09-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help