Thread (5 messages) 5 messages, 4 authors, 2025-09-09

Re: [PATCH] net: atlantic: make RX page order tunable via module param

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-09-08 17:12:26
Also in: lkml

+static unsigned int rxpageorder = AQ_CFG_RX_PAGEORDER;
+module_param_named(rxpageorder, rxpageorder, uint, 0644);
+MODULE_PARM_DESC(rxpageorder, "RX page order");
Sorry, but netdev does not like module params. They are a bad API to
use. Please find a different way to do this.

Also, there is a comment:

	/* Only order-2 is allowed if XDP is enabled */
	if (READ_ONCE(self->xdp_prog)) {

You need to ensure this assumption is not broken.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help