Re: [PATCH 1/1] ipv6: Check AF_UNSPEC in ip6_route_multipath_add()
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-09-04 16:03:03
Also in:
linux-kernel-mentees, lkml
On Mon, 04 Aug 2025 20:42:53 +0000 Maksimilijan Marosevic wrote:
This check was removed in commit e6f497955fb6 ("ipv6: Check GATEWAY
in rtm_to_fib6_multipath_config().") as part of rt6_qualify_for ecmp().
The author correctly recognises that rt6_qualify_for_ecmp() returns
false if fb_nh_gw_family is set to AF_UNSPEC, but then mistakes
AF_UNSPEC for AF_INET6 when reasoning that the check is unnecessary.
This means certain malformed entries don't get caught in
ip6_route_multipath_add().
This patch reintroduces the AF_UNSPEC check while respecting changes
of the initial patch.Hi Maksimilijan! Are you planning to repost this with a test? If not I suppose we can enlist the author of the commit to help with the selftest..