Re: [RFC PATCH net-next] ppp: enable TX scatter-gather
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-09-04 12:51:32
Also in:
lkml
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index f9f0f16c41d1..3bf37871a1aa 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c@@ -1710,6 +1710,12 @@ pad_compress_skb(struct ppp *ppp, struct sk_buff *skb) ppp->xcomp->comp_extra + ppp->dev->hard_header_len; int compressor_skb_size = ppp->dev->mtu + ppp->xcomp->comp_extra + PPP_HDRLEN; + /* Until we fix the compressor need to make sure data portion is + * linear. + */ + if (skb_linearize(skb)) + return NULL;
The word 'fix' suggest something is broken. I don't think that is true, its just a limitation of the compressor. Please avoid 'fix'. Andrew