Re: [PATCH v2] net/smc: Replace use of strncpy on NUL-terminated string with strscpy
From: Mahanta Jambigi <mjambigi@linux.ibm.com>
Date: 2025-09-02 06:40:22
Also in:
linux-kernel-mentees, linux-rdma, linux-s390, lkml
On 01/09/25 8:34 am, James Flowers wrote:
quoted hunk ↗ jump to hunk
strncpy is deprecated for use on NUL-terminated strings, as indicated in Documentation/process/deprecated.rst. strncpy NUL-pads the destination buffer and doesn't guarantee the destination buffer will be NUL terminated. Signed-off-by: James Flowers <redacted> --- V1 -> V2: Replaced with two argument version of strscpy Note: this has only been compile tested. net/smc/smc_pnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c index 76ad29e31d60..b90337f86e83 100644 --- a/net/smc/smc_pnet.c +++ b/net/smc/smc_pnet.c@@ -450,7 +450,7 @@ static int smc_pnet_add_ib(struct smc_pnettable *pnettable, char *ib_name, return -ENOMEM; new_pe->type = SMC_PNET_IB; memcpy(new_pe->pnet_name, pnet_name, SMC_MAX_PNETID_LEN); - strncpy(new_pe->ib_name, ib_name, IB_DEVICE_NAME_MAX); + strscpy(new_pe->ib_name, ib_name);
I tested your changes by creating a Software PNET ID using *smc_pnet* tool & it works fine. Your changes are similar to ae2402b(net/smc: replace strncpy with strscpy) commit. Reviewed-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
new_pe->ib_port = ib_port; new_ibdev = true;