On Tue, Sep 23, 2025 at 10:46 PM Pavan Chebbi [off-list ref] wrote:

quoted

This file is redundant since ulp.h already holds every thing "aux", so this
struct belongs there. Also the only place you include this is file:
   drivers/net/ethernet/broadcom/bnxt/bnxt.h

Hi Saeed, later bnxt fwctl will include it as well. You could say it
can still be
inside ulp.h but fwctl is only going to need bnxt_aux_priv. So I
carved it out of
earlier bnxt.h.

On second thought, the struct might not have belonged to bnxt.h in the
first place.
So moving it to ulp.h seems like a better thing to do. Thanks.