Thread (4 messages) 4 messages, 3 authors, 2025-09-23

Re: [PATCH] net: phy: bcm5481x: Fix GMII/MII/MII-Lite selection

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-09-23 16:46:21

quoted
quoted
+	if (!phy_interface_is_rgmii(phydev)) {
+		/* Misc Control: GMII/MII/MII-Lite Mode (not RGMII) */
+		err = bcm54xx_auxctl_write(phydev, MII_BCM54XX_AUXCTL_SHDWSEL_MISC,
+					   MII_BCM54XX_AUXCTL_MISC_WREN |
+					   MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RGMII_SKEW_EN |
This is a bit confusing. If it is NOT RGMII, you set RGMII_SKEW_EN? I
could understand the opposite, clear the bit...
Bit 7 is documented as RGMII Enable
Thanks Florian

However, this still does not explain the
!phy_interface_is_rgmii(phydev).

	 Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help