Thread (8 messages) 8 messages, 2 authors, 2025-09-17

Re: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-09-17 21:13:14

On Wed, 17 Sep 2025 15:38:45 +0800 Jiawen Wu wrote:
quoted
quoted
Deleting VFs will reset these configurations.  
You shouldn't reset user-set configuration of the PF when SR-IOV
is disabled.  
But the maximum queue number of PF is different when SRIOV is
enabled or disabled?

And for the global RSS table (non SR-IOV mode) or multiple RSS table
(SR-IOV mode), the table size is different on hardware design.

How could I keep the RSS redirection table during the mode switching?
Only if the user requested a particular config.

If netif_is_rxfh_configured() returns true and the RSS table contains
the ring you're trying to disable you should reject the attempt to
enable SRIOV.

For the change in table size you can just reject if
netif_is_rxfh_configured() for simplicity (user can reset the table using 
ethtool -X $ifc default
You could support "shrinking" the table if both sub-tables are
identical. But IDK if its worth the effort. Setting custom indir tables
is fairly rare.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help