Re: [PATCH net-next v2 1/3] net: dst_cache: implement RCU variants for dst_cache helpers
From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-09-16 09:28:18
From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-09-16 09:28:18
On 9/12/25 1:24 PM, Marek Mietus wrote:
-static struct dst_entry *dst_cache_per_cpu_get(struct dst_cache *dst_cache,
- struct dst_cache_pcpu *idst)
+static void dst_cache_per_cpu_dst_set(struct dst_cache_pcpu *dst_cache,
+ struct dst_entry *dst, u32 cookie)
+{
+ if (dst == dst_cache->dst && cookie == dst_cache->cookie)
+ return;The additional checks above could possibly make sense, but should never trigger as the _set operation should follow a failing lookup. Also are unrelated with the other changes here, they should land in a separate patch - or be dropped. Thanks, Paolo