On Tue,  9 Sep 2025 07:43:31 +0200 Marek Mietus wrote:

+/**
+ *	dst_cache_get_ip4_rcu - perform cache lookup and fetch ipv4 source
+ *	address without taking a reference on the dst

This belongs in the body, summary can be just 

				lookup cache and ipv4 source under RCU

+ *	@dst_cache: the cache
+ *	@saddr: return value for the retrieved source address
+ *
+ *	Must be called with local BH disabled, and within an rcu read side
+ *	critical section
+ */
+struct rtable *dst_cache_get_ip4_rcu(struct dst_cache *dst_cache, __be32 *saddr);

Return: values needs to be documented these days (kernel-doc -Wall ..).

While at it please remove the old school indent by a tab.
-- 
pw-bot: cr