RE: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp_target

________________________________________
From: Paolo Abeni <pabeni@redhat.com>
Sent: Tuesday, September 9, 2025 6:21 AM
To: David Wilder; netdev@vger.kernel.org
Cc: jv@jvosburgh.net; pradeeps@linux.vnet.ibm.com; Pradeep Satyanarayana; i.maximets@ovn.org; Adrian Moreno Zapata; Hangbin Liu
Subject: [EXTERNAL] Re: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp_target

On 7/15/25 12:54 AM, David Wilder wrote:

quoted

Replacing the definition of bond_params.arp_targets (__be32 arp_targets[])
with:

struct bond_arp_target {
      __be32                  target_ip;
      struct bond_vlan_tag    *tags;
      u32                     flags;
};

The above struct is going to be allocated on the stack and has 2 holes 4
bytes each.

If you change the layout as follow:

struct bond_arp_target {
        __be32                  target_ip;
        u32                     flags;
        struct bond_vlan_tag    *tags;
};

the struct size will be 8 bytes less.

/P

Cool. Thank you for the suggestion Paolo.
I will make the change.