Re: [PATCH net-next v10 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

On 9/9/25 20:55, David Wilder wrote:

________________________________________
From: Nikolay Aleksandrov <razor@blackwall.org>
Sent: Tuesday, September 9, 2025 6:54 AM
To: David Wilder; netdev@vger.kernel.org
Cc: jv@jvosburgh.net; pradeeps@linux.vnet.ibm.com; Pradeep Satyanarayana; i.maximets@ovn.org; Adrian Moreno Zapata; Hangbin Liu; stephen@networkplumber.org; horms@kernel.org
Subject: [EXTERNAL] Re: [PATCH net-next v10 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

quoted

On 9/5/25 01:18, David Wilder wrote:

quoted

Changes since V4:
1)Dropped changes to proc and sysfs APIs to bonding.  These APIs
do not need to be updated to support new functionality.  Netlink
and iproute2 have been updated to do the right thing, but the
other APIs are more or less frozen in the past.

I'm sorry I'm late (v10) to the party, but I keep wondering:
Why keep extending sysfs support? It is supposed to be deprecated and most
of this set adds changes around bond sysfs option handling to parse a new format.

IMHO this new extension should be available through netlink only, that is much
simpler, less error-prone and doesn't require string parsing. At worst sysfs
should only show the values properly.

Cheers,
Nik

Hi Nic
Thanks for the reviewing my patches..
I did originally extend the sysfs to support the extension, but dropped that support.
The only remaining change related to sysfs  keeps the original support working with out
the new extension.

Ohhh my bad, I need better glasses. :) I read the cover letter and saw the new format, missed
the part where sysfs was dropped. Sorry for the noise!

I do have one comment, but I'll add that to the respective patch.