Thread (19 messages) 19 messages, 4 authors, 2025-09-04

Re: [PATCH net-next 5/8] selftests: traceroute: Use require_command()

From: David Ahern <dsahern@kernel.org>
Date: 2025-09-02 02:38:16
Also in: linux-security-module

On 9/1/25 2:30 AM, Ido Schimmel wrote:
Use require_command() so that the test will return SKIP (4) when a
required command is not present.

Before:

 # ./traceroute.sh
 SKIP: Could not run IPV6 test without traceroute6
 SKIP: Could not run IPV4 test without traceroute
 $ echo $?
 0

After:

 # ./traceroute.sh
 TEST: traceroute6 not installed                                    [SKIP]
 $ echo $?
 4

Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 tools/testing/selftests/net/traceroute.sh | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: David Ahern <dsahern@kernel.org>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help